Sahina Bose has posted comments on this change. Change subject: engine: DB persistent scheduler ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/36297/1/packaging/dbscripts/upgrade/03_06_0590_insert_quartz_tables.sql File packaging/dbscripts/upgrade/03_06_0590_insert_quartz_tables.sql: Line 1: -- Thanks to Patrick Lightbody for submitting this... Line 2: -- > Please remove all TWS from file Done Line 3: -- In your Quartz properties file, you'll need to set Line 4: -- org.quartz.jobStore.driverDelegateClass = org.quartz.impl.jdbcjobstore.PostgreSQLDelegate Line 5: Line 6: drop table qrtz_fired_triggers; Line 2: -- Line 3: -- In your Quartz properties file, you'll need to set Line 4: -- org.quartz.jobStore.driverDelegateClass = org.quartz.impl.jdbcjobstore.PostgreSQLDelegate Line 5: Line 6: drop table qrtz_fired_triggers; > Please use either UPPERCASE or lowercase fro keywords along the whole file Done Line 7: DROP TABLE QRTZ_PAUSED_TRIGGER_GRPS; Line 8: DROP TABLE QRTZ_SCHEDULER_STATE; Line 9: DROP TABLE QRTZ_LOCKS; Line 10: drop table qrtz_simple_triggers; Line 3: -- In your Quartz properties file, you'll need to set Line 4: -- org.quartz.jobStore.driverDelegateClass = org.quartz.impl.jdbcjobstore.PostgreSQLDelegate Line 5: Line 6: drop table qrtz_fired_triggers; Line 7: DROP TABLE QRTZ_PAUSED_TRIGGER_GRPS; > Please change all drop tables to Done Line 8: DROP TABLE QRTZ_SCHEDULER_STATE; Line 9: DROP TABLE QRTZ_LOCKS; Line 10: drop table qrtz_simple_triggers; Line 11: drop table qrtz_cron_triggers; Line 16: drop table qrtz_calendars; Line 17: Line 18: CREATE TABLE qrtz_job_details Line 19: ( Line 20: SCHED_NAME VARCHAR(120) NOT NULL, > All column names should be in lowercase Done Line 21: JOB_NAME VARCHAR(200) NOT NULL, Line 22: JOB_GROUP VARCHAR(200) NOT NULL, Line 23: DESCRIPTION VARCHAR(250) NULL, Line 24: JOB_CLASS_NAME VARCHAR(250) NOT NULL, http://gerrit.ovirt.org/#/c/36297/1/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 160: <validate-on-match>true</validate-on-match> Line 161: <check-valid-connection-sql>select 1</check-valid-connection-sql> Line 162: </validation> Line 163: </datasource> Line 164: > please remove spaces Done Line 165: <datasource jndi-name="java:/ENGINEDataSourceNoTx" pool-name="ENGINEDataSourceNoTx" enabled="true" use-ccm="false" jta="false"> Line 166: <connection-url><![CDATA[$getstring('ENGINE_DB_URL')]]></connection-url> Line 167: <driver>postgresql</driver> Line 168: <transaction-isolation>TRANSACTION_READ_COMMITTED</transaction-isolation> -- To view, visit http://gerrit.ovirt.org/36297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
