Allon Mureinik has posted comments on this change. Change subject: core: find connections with same password ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36320/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java: Line 162: // result, Line 163: // we can't query the connections to check if connection with the exact Line 164: // same details was already added - so we query the connections with the same (currently relevant) details and Line 165: // then compare the password after it was already Line 166: // decrypted. This should be in the javadoc, to make it more visible to IDEs, but other than that, no complaints. Line 167: List<StorageServerConnections> connections = Line 168: DbFacade.getInstance().getStorageServerConnectionDao().getAllForConnection(connection); Line 169: for (StorageServerConnections dbConnection : connections) { Line 170: if (ObjectUtils.objectsEqual(dbConnection.getpassword(), connection.getpassword())) { -- To view, visit http://gerrit.ovirt.org/36320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc70dd4e7988f4ea4597f016c9de8419c17adfa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
