Liron Aravot has posted comments on this change.

Change subject: core: find connections with same password
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/36320/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java:

Line 81:             return false;
Line 82:         }
Line 83: 
Line 84:         Guid storagePoolId = 
Guid.isNullOrEmpty(getParameters().getVdsId()) ? null : 
getVds().getStoragePoolId();
Line 85: 
will be removed on the next patchset
Line 86:         if (isConnWithSameDetailsExists(paramConnection, 
storagePoolId)) {
Line 87:             return 
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_CONNECTION_ALREADY_EXISTS);
Line 88:         }
Line 89:         // If a Guid is not supplied, we won't attempt to [dis]connect.


-- 
To view, visit http://gerrit.ovirt.org/36320
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fc70dd4e7988f4ea4597f016c9de8419c17adfa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to