Moti Asayag has posted comments on this change. Change subject: engine: Addition to ReplacementUtils ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/35915/4/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java: Line 34: * <li>The property name and its replacement items.</li> Line 35: * <li>The property counter name and the items size.</li> Line 36: * </ul> Line 37: */ Line 38: public static Collection<String> replaceWith(String propertyName, List<?> items, String separator, int maxNumberOfPrintedItems) { on the same manner we should verify Validate.notNull(separator); To prevent the output from looking like: "the items xnullbxcnull..." Line 39: Validate.isTrue(maxNumberOfPrintedItems >= 0); Line 40: int size = Math.min(maxNumberOfPrintedItems, items.size()); Line 41: List<String> printedItems = new ArrayList<String>(size); Line 42: http://gerrit.ovirt.org/#/c/35915/4/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java: Line 72: Collection<String> replacements = ReplacementUtils.replaceWith(PROPERTY_NAME, items, separator , numOfElementsToShow); Line 73: assertTrue(validateReplacementElementCount(replacements, separator, numOfElementsToShow)); Line 74: } Line 75: Line 76: @Test please add another test (or 2, depends on validating the nullity of the separator) to expect IllegaltArgumentException in case of invalid sep or number of items to print. Line 77: public void containBiggerThanDefaultNumberOfElements() { Line 78: List<Object> items = createItems(); Line 79: String separator = "sep"; Line 80: -- To view, visit http://gerrit.ovirt.org/35915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f64b31b69574aff68a0706dd7d6afa3037511a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
