Amit Aviram has posted comments on this change.

Change subject: engine: Addition to ReplacementUtils
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/35915/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java:

Line 10: 
Line 11: public class ReplacementUtils {
Line 12: 
Line 13:     protected static final int DEFAULT_MAX_NUMBER_OF_PRINTED_ITEMS = 5;
Line 14:     protected static final String DEFAULT_SEPARATOR = "," + 
System.getProperty("line.separator");
> please replace System.getProperty("line.separator") with System.lineSeparat
Done
Line 15: 
Line 16:     /**
Line 17:      * Replace a property defined within a message with a bounded 
number of elements.<br>
Line 18:      * In addition, if a counter appears in the message, it will be 
replaced with the elements size:<br>


-- 
To view, visit http://gerrit.ovirt.org/35915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77f64b31b69574aff68a0706dd7d6afa3037511a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to