Yair Zaslavsky has posted comments on this change. Change subject: engine: Introduce ClusterValidator ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36242/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java: Line 43: .when(cluster.supportsVirtService() && !cpuExists()); Line 44: } Line 45: Line 46: protected boolean cpuExists() { Line 47: return CpuFlagsManagerHandler.checkIfCpusExist(cluster.getcpu_name(), cluster.getcompatibility_version()); What is your take on abolishing the static methods of CpuFlagsManagerHandler, turning it into an object with non static methods, and maybe one day have it as a singlton bean (for now - just ... new CpuFlagsManagerHandler). Line 48: } Line 49: Line 50: public ValidationResult versionSupported() { Line 51: return ValidationResult.failWith(VersionSupport.getUnsupportedVersionMessage()) -- To view, visit http://gerrit.ovirt.org/36242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I005cca2295a215d1a694d3d7604dabc59a77595c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
