Oved Ourfali has posted comments on this change. Change subject: engine: Introduce ClusterValidator ......................................................................
Patch Set 3: Code-Review+1 (1 comment) minor typo. http://gerrit.ovirt.org/#/c/36242/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java: Line 92: .unless(cluster.supportsGlusterService() || cluster.supportsVirtService()); Line 93: } Line 94: Line 95: public ValidationResult mixedClusterServicesSupported() { Line 96: boolean mixedClusterEnavled = Config.<Boolean> getValue(ConfigValues.AllowClusterWithVirtGlusterEnabled); typo s/Enavled/Enabled Line 97: return ValidationResult.failWith(VdcBllMessages.VDS_GROUP_ENABLING_BOTH_VIRT_AND_GLUSTER_SERVICES_NOT_ALLOWED) Line 98: .when(cluster.supportsGlusterService() && cluster.supportsVirtService() && !mixedClusterEnavled); Line 99: } Line 100: -- To view, visit http://gerrit.ovirt.org/36242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I005cca2295a215d1a694d3d7604dabc59a77595c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
