Ondřej Macháček has posted comments on this change. Change subject: aaa: fix error messages of basic authentication filter ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36206/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java: Line 149: log.error("User {} authentication failed. profile is {}. Invocation Result code is {}. Authn result code is {}", Line 150: userProfile.userName, Line 151: userProfile.profile.getName(), Line 152: outputMap.<Integer> get(Base.InvokeKeys.RESULT), Line 153: outputMap.<Integer> get(Authn.InvokeKeys.RESULT) I would welcome some string instead of number here in future. Message: "Invocation Result code is 0. Authn result code is 12" Don't say much what's wrong. Line 154: ); Line 155: } Line 156: } Line 157: } -- To view, visit http://gerrit.ovirt.org/36206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ec060ee36bc94a2c8b40501358b21e4da44c4ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
