Alon Bar-Lev has uploaded a new change for review.

Change subject: aaa: fix error messages of basic authentication filter
......................................................................

aaa: fix error messages of basic authentication filter

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1174731
Change-Id: I3ec060ee36bc94a2c8b40501358b21e4da44c4ca
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/36206/1

diff --git 
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
 
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
index 4cb46e0..cab8a87 100644
--- 
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
+++ 
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
@@ -114,7 +114,7 @@
     private void handleCredentials(HttpServletRequest request, String user, 
String password) {
         UserProfile userProfile = translateUser(user);
         if (userProfile == null || userProfile.profile == null) {
-            log.error("Error in obtaining profile {}", userProfile.profile);
+            log.error("Cannot obtain profile for user {}", user);
         } else {
             ExtMap outputMap = userProfile.profile.getAuthn().invoke(new 
ExtMap().mput(
                     Base.InvokeKeys.COMMAND,
@@ -146,10 +146,11 @@
                             userProfile.userName
                             );
                 }
-                log.error("Failure in authentication to profile {}. Invocation 
Result code is {}. Authn result code is {}",
-                                userProfile.profile,
-                                 outputMap.<Integer> 
get(Base.InvokeKeys.RESULT),
-                                 outputMap.<Integer> 
get(Authn.InvokeKeys.RESULT)
+                log.error("User {} authentication failed. profile is {}. 
Invocation Result code is {}. Authn result code is {}",
+                                userProfile.userName,
+                                userProfile.profile.getName(),
+                                outputMap.<Integer> 
get(Base.InvokeKeys.RESULT),
+                                outputMap.<Integer> 
get(Authn.InvokeKeys.RESULT)
                         );
              }
         }


-- 
To view, visit http://gerrit.ovirt.org/36206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ec060ee36bc94a2c8b40501358b21e4da44c4ca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to