Vojtech Szocs has posted comments on this change.

Change subject: webadmin: Store subtab height in browser
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/35178/2/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java
File 
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java:

Line 30:     private boolean subTabPanelVisible;
Line 31: 
Line 32:     public AbstractSideTabWithDetailsView(
Line 33:             SearchableTableModelProvider<T, M> modelProvider,
Line 34:             ApplicationResources applicationResources, final 
ClientStorage clientStorage) {
> Yes there is, I am passing it to anonymous class instance below and it need
Sorry, you're right, I missed the part below.
Line 35:         this.modelProvider = modelProvider;
Line 36:         this.table = createActionTable();
Line 37:         this.table.showRefreshButton();
Line 38:         this.clientStorage = clientStorage;


-- 
To view, visit http://gerrit.ovirt.org/35178
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a7cb529914703e71da9ac323ee15bdb68b1449a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to