Alexander Wels has posted comments on this change. Change subject: webadmin: Store subtab height in browser ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/35178/2/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java: Line 30: private boolean subTabPanelVisible; Line 31: Line 32: public AbstractSideTabWithDetailsView( Line 33: SearchableTableModelProvider<T, M> modelProvider, Line 34: ApplicationResources applicationResources, final ClientStorage clientStorage) { > No need for final here :-) Yes there is, I am passing it to anonymous class instance below and it needs to be final for that. Line 35: this.modelProvider = modelProvider; Line 36: this.table = createActionTable(); Line 37: this.table.showRefreshButton(); Line 38: this.clientStorage = clientStorage; Line 45: public void onResize() { Line 46: super.onResize(); Line 47: if (subTabPanelVisible) { Line 48: clientStorage.setLocalItem(SubTabHelper.SUB_TAB_HEIGHT_KEY, Line 49: String.valueOf(subTabPanelContainer.getOffsetHeight())); > If we already have SubTabHelper, wouldn't it make sense to have a method li Done Line 50: } Line 51: } Line 52: }; Line 53: http://gerrit.ovirt.org/#/c/35178/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainContentView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainContentView.java: Line 26: public void onResize() { Line 27: super.onResize(); Line 28: if (subTabPanelVisible) { Line 29: clientStorage.setLocalItem(SubTabHelper.SUB_TAB_HEIGHT_KEY, Line 30: String.valueOf(subTabPanelContainer.getOffsetHeight())); > Same comment as in AbstractSideTabWithDetailsView.java Done Line 31: } Line 32: } Line 33: }; Line 34: this.clientStorage = clientStorage; -- To view, visit http://gerrit.ovirt.org/35178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a7cb529914703e71da9ac323ee15bdb68b1449a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
