Oved Ourfali has posted comments on this change. Change subject: aaa: two providers produce the same "domain id" ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Seems good to me. One comment, just to make sure you haven't deleted a line you shouldn't have deleted. Once you answer this I'll give +2. http://gerrit.ovirt.org/#/c/36092/1/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java: Line 17: model.setId(entity.getId().toString()); Line 18: if (!StringUtils.isEmpty(entity.getDomain())) { Line 19: Domain dom = new Domain(); Line 20: dom.setName(entity.getDomain()); Line 21: dom.setId(DirectoryEntryIdUtils.encode(dom.getName())); don't you need here also model.setDomain? Line 22: } Line 23: model.setDomainEntryId(DirectoryEntryIdUtils.encode(entity.getExternalId())); Line 24: model.setNamespace(entity.getNamespace()); Line 25: return model; -- To view, visit http://gerrit.ovirt.org/36092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieddb2c31645d7276652db17df190bc4f2cfdaacb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
