Eli Mesika has posted comments on this change. Change subject: backend: Add HostDev passthrough support ......................................................................
Patch Set 10: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/35892/10/packaging/dbscripts/host_device_sp.sql File packaging/dbscripts/host_device_sp.sql: Line 11: v_vm_id UUID) Line 12: RETURNS VOID Line 13: AS $procedure$ Line 14: BEGIN Line 15: SET CONSTRAINTS ALL DEFERRED; why do you need that ??? Line 16: INSERT INTO host_device( Line 17: host_id, Line 18: device_name, Line 19: parent_device_name, Line 52: v_vm_id UUID) Line 53: RETURNS VOID Line 54: AS $procedure$ Line 55: BEGIN Line 56: SET CONSTRAINTS ALL DEFERRED; same Line 57: UPDATE host_device Line 58: SET Line 59: host_id = v_host_id, Line 60: device_name = v_device_name, Line 73: CREATE OR REPLACE FUNCTION DeleteHostDevice(v_host_id UUID, v_device_name UUID) Line 74: RETURNS VOID Line 75: AS $procedure$ Line 76: BEGIN Line 77: SET CONSTRAINTS ALL DEFERRED; same Line 78: DELETE Line 79: FROM host_device Line 80: WHERE host_id = v_host_id AND device_name = v_device_name; Line 81: END; $procedure$ http://gerrit.ovirt.org/#/c/35892/10/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 251: select fn_db_add_config_value('HostDevicePassthroughSupported','false','3.2'); Line 252: select fn_db_add_config_value('HostDevicePassthroughSupported','false','3.3'); Line 253: select fn_db_add_config_value('HostDevicePassthroughSupported','false','3.4'); Line 254: select fn_db_add_config_value('HostDevicePassthroughSupported','false','3.5'); Line 255: please replace all the above with select fn_db_add_config_value_for_versions_up_to('HostDevicePassthroughSupported', 'false', '3.5'); Line 256: -- by default use no proxy Line 257: select fn_db_add_config_value('SpiceProxyDefault','','general'); Line 258: Line 259: --Handling Install virtualization software on Add Host -- To view, visit http://gerrit.ovirt.org/35892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5575c0db797d7d04339c4b309bb4325e853ffed Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
