Martin Betak has posted comments on this change. Change subject: backend: Add HostDev passthrough support ......................................................................
Patch Set 10: *DRAFT STATUS:* RefreshHostDevices, GetDevicesByHostId and GetDeviceByHostIdAndDeviceName commands/queries are working and with the dependant REST api patch supports: GET /api/hosts/<id>/devices GET /api/hosts/<id>/devices;force GET /api/hosts/<id>/devices/<device_name> where 2nd form will trigger hostDevListByCaps VDSM verb before returning. (Similar as /api/hosts/<id>;force trigger RefreshHostCapabilities. Implementing hard DB constraint for (host_id, parent_name) for updates/saves which may be out of (topological tree) order required usage of batch operation in dao and SET CONSTRAINTS ALL DEFERRED in stored procedures to check constrains on transaction COMMIT. Otherwise we would have to do expensive topological sorting on the engine side, before each save/remove. Missing features: - action_group infrastructure for new MANIPULATE_HOST_DEVICE ActionGroup and all user roles stuff required, for now as a crutch we are reusing the MANIPULATE_HOST action group used by RefreshHostCapabilitiesCommand (maybe we don't need the new action group after all) - DAO tests, trim fixtures.xml (from existing dump of 120 devices) - RestApi tests - some restapi HATEOAS hyperlinks (dev -> parent dev, dev -> self) -- To view, visit http://gerrit.ovirt.org/35892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5575c0db797d7d04339c4b309bb4325e853ffed Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
