Einav Cohen has posted comments on this change.
Change subject: UI: change Make-Template to more readable text
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 132:
Line 133: @DefaultStringValue("Storage Domain")
Line 134: String makeTemplateStorageDomainLabel();
Line 135:
Line 136: @DefaultStringValue("Allow all users to access this Template")
The bz also says to reverse the logic, however no logic has been reversed in
this patch... logic must be reversed if we want to use the text-above (i.e. if
text-box was checked by default, it should now be un-checked by default, we
should send to backend the opposite value according to the checked/unchecked
status, etc.)
Line 137: String makeTemplateIsTemplatePrivateEditorLabel();
Line 138:
Line 139: @DefaultStringValue("Description")
Line 140: String virtualMachineSnapshotCreatePopupDescriptionLabel();
--
To view, visit http://gerrit.ovirt.org/7216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9055763d66b09da175810ad3ba2ace0ff8316264
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
