Yair Zaslavsky has posted comments on this change. Change subject: aaa: fix session timeout ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/35897/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 212: Line 213: // Public services Line 214: GetDomainList(VdcQueryAuthType.User), Line 215: GetAAAProfileList(VdcQueryAuthType.User, false), Line 216: RegisterVds(VdcQueryAuthType.User, false), > so can't you detect public queries? they are using different entry point to Yes they do. and inndeed you will see notice in the runPublicQuery the enums of these. However, in the case of SystemStatistics, this is not a public query, and we would not want the session to be refreshed upon this query. Since in REST-API there is no notion of public query, I think that that in its case its all about whether the query should refresh the session or not. Line 217: CheckDBConnection(VdcQueryAuthType.User, false), Line 218: ValidateSession(VdcQueryAuthType.User, false), Line 219: GetValueBySession(false), Line 220: -- To view, visit http://gerrit.ovirt.org/35897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6640beef3ca28f95def87ac5e29d41f75b0fddd8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
