Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix session timeout ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/35897/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java: Line 1 Line 2 Line 3 is it safe to assume that all GetConfigurationValueParameters are not actually operations that are issued by user and can all be ignored, just like the system metrics? http://gerrit.ovirt.org/#/c/35897/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 212: Line 213: // Public services Line 214: GetDomainList(VdcQueryAuthType.User), Line 215: GetAAAProfileList(VdcQueryAuthType.User, false), Line 216: RegisterVds(VdcQueryAuthType.User, false), not sure why the above two do not refresh session, are these called in an idle loop? Line 217: CheckDBConnection(VdcQueryAuthType.User, false), Line 218: ValidateSession(VdcQueryAuthType.User, false), Line 219: GetValueBySession(false), Line 220: -- To view, visit http://gerrit.ovirt.org/35897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6640beef3ca28f95def87ac5e29d41f75b0fddd8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
