Martin Mucha has posted comments on this change. Change subject: core: Added SerialMultipleActionsRunner ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35192/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialMultipleActionsRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialMultipleActionsRunner.java: Line 27: } Line 28: } Line 29: Line 30: @Override Line 31: protected void runCommands() { > this runner doesn't provide any additional functionality rather than having ok, I'll drop this runner. I'd suppose that previous refactoring with some methods being extracted, which allows better reusability of MultipleActionsRunner, should be abandoned as well, since it's not needed now. Line 32: for (CommandBase<?> command : getCommands()) { Line 33: CorrelationIdTracker.setCorrelationId(command.getCorrelationId()); Line 34: command.canDoActionOnly(); Line 35: if (command.getReturnValue().getCanDoAction()) { -- To view, visit http://gerrit.ovirt.org/35192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460879f1dfd5f165e58049314d08dd45d8dbfc4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
