Moti Asayag has posted comments on this change. Change subject: core: Added SerialMultipleActionsRunner ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35192/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialMultipleActionsRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialMultipleActionsRunner.java: Line 27: } Line 28: } Line 29: Line 30: @Override Line 31: protected void runCommands() { > Moti - I assume by your suggestion you will have parrent command X that wil this runner doesn't provide any additional functionality rather than having the following executed in the command: for (VdcActionParameters param : params) { runInternalAction(actionType, param); } and if that commonly used we can consider adding it to the CommandBase as a method, however i don't see how this is too verbose. this will achieve same result and functionality without the overhead of having a specific runner for it. and also - MultipleActionsRunnersFactory assigns a specific runner for each command type. There is no method just to pick the invocation method, so from client perspective, any multiple action command will become serial. Line 32: for (CommandBase<?> command : getCommands()) { Line 33: CorrelationIdTracker.setCorrelationId(command.getCorrelationId()); Line 34: command.canDoActionOnly(); Line 35: if (command.getReturnValue().getCanDoAction()) { -- To view, visit http://gerrit.ovirt.org/35192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460879f1dfd5f165e58049314d08dd45d8dbfc4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
