Allon Mureinik has posted comments on this change.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
small (read: optional) comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
Line 47: }
Line 48: }
Line 49:
Line 50: boolean noImagesRemovedYet = true;
Line 51: for (final DiskImage image : images) {
why final?
Line 52: if (mImagesToBeRemoved.contains(image.getImageId())) {
Line 53: RemoveImageParameters tempVar = new
RemoveImageParameters(image.getImageId());
Line 54:
tempVar.setParentCommand(getParameters().getParentCommand());
Line 55:
tempVar.setParentParemeters(getParameters().getParentParameters());
--
To view, visit http://gerrit.ovirt.org/5806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
