Maor Lipchuk has posted comments on this change. Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051) ......................................................................
Patch Set 7: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 182: default: agreed. new message will be added as follow "VM was removed. but disks $(disk names) were not be able to be removed and will be floating disks with ILLEGAL state" Line 239: // Get all disk images for VM (VM should not have any image disk associated with it). agreed. Line 258: */ Agreed regarding the RemoveImageCommand. For now detach disk does not allow to detach a disk that has snapshots. this behaviour should be changed in the future that detach will use collapse all snapshot for a disk. For this specific case when we remove a VM, we can't be sure if the disk was related to the VM in this way or another, so we prefer to change its status to ILLEGAL. -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
