Moti Asayag has posted comments on this change. Change subject: core: Add JPA Java infrastructure ......................................................................
Patch Set 20: (3 comments) http://gerrit.ovirt.org/#/c/33835/20/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java: Line 27: } Line 28: } Line 29: } Line 30: em = emf.createEntityManager(); Line 31: tl.set(em); Could you elaborate on this ? What is the purpose of binding the entity manager to the thread local ? Wouldn't it cause for a persistence context to be available in more than a single flow ? Line 32: } Line 33: return em; Line 34: } Line 35: Line 43: Line 44: public void save(T entity) { Line 45: EntityManager em = getEntityManager(); Line 46: Line 47: if (!em.getTransaction().isActive()) { I'm not sure this is a valid assumption based on the way the current code is written (especially the bll commands) for example, if a command is being executed in a suppress mode, the opened transaction in the "save(T)" will remain as part of the state of the EntityManager. Line 48: em.getTransaction().begin(); Line 49: } Line 50: em.merge(entity); Line 51: if (autoCommit) { Line 46: Line 47: if (!em.getTransaction().isActive()) { Line 48: em.getTransaction().begin(); Line 49: } Line 50: em.merge(entity); shouldn't we inspect here for ConstraintViolationException, now that we enforce the BeanValidation per persisted entity ? Line 51: if (autoCommit) { Line 52: em.flush(); Line 53: em.getTransaction().commit(); Line 54: } -- To view, visit http://gerrit.ovirt.org/33835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82bf8cc647426e37dc42a113867c52699c3f0b Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
