Yair Zaslavsky has posted comments on this change. Change subject: core: Add JPA Java infrastructure ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/33835/20/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java: Line 11: import javax.persistence.Query; Line 12: Line 13: public abstract class HibernateFacade<T, K extends Serializable> extends BaseDAODbFacade { Line 14: private static volatile EntityManagerFactory emf; Line 15: private static ThreadLocal<EntityManager> tl = new ThreadLocal<EntityManager>(); by the way, isnnt the todo comment should be here? i mean, the reason u use ThreadLocal is because you're not injecting yet, right? Line 16: private static boolean autoCommit = true; Line 17: Line 18: // TODO: Should be injected, once we start using IoC Line 19: protected static EntityManager getEntityManager() { -- To view, visit http://gerrit.ovirt.org/33835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82bf8cc647426e37dc42a113867c52699c3f0b Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
