Yair Zaslavsky has posted comments on this change. Change subject: core : Persist engine session on login and delete on logout ......................................................................
Patch Set 8: Code-Review+1 (1 comment) minor comment. http://gerrit.ovirt.org/#/c/35361/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java: Line 96: private void persistEngineSession(String sessionId) { Line 97: SessionInfo sessionInfo = getSessionInfo(sessionId); Line 98: if (sessionInfo != null) { Line 99: EngineSession engineSession = new EngineSession(getUser(sessionId, false)); Line 100: engineSession.setEngineSessionId(sessionId); instead of setEngineSessionId - why not having it at ctor? Line 101: sessionInfo.contentOfSession.put(ENGINE_SESSION_SEQ_ID, getDbFacade().getEngineSessionDao().save(engineSession)); Line 102: } Line 103: } Line 104: -- To view, visit http://gerrit.ovirt.org/35361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
