Ravi Nori has posted comments on this change. Change subject: core : Persist engine session on login and delete on logout ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/35361/9/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java: Line 64: Line 65: @Test Line 66: public void testGetDataAndSetDataWithEmptySession() { Line 67: assertNull("Get should return null with an empty session", container.getData("", TEST_KEY, false)); Line 68: clearSession(); > why not have this at @Before? I had it in @After to clear the session after the test have been done but since we are throwing an exception if session is not found and clear is called the last test testRefreshUserSessionAfterExpiration was failing. Line 69: } Line 70: Line 71: @Test Line 72: public void testGetDataAndSetDataWithFullSession() { http://gerrit.ovirt.org/#/c/35361/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java: Line 47 Line 48 Line 49 Line 50 Line 51 > leave? Will do Line 77 Line 78 Line 79 Line 80 Line 81 > leave? Will do -- To view, visit http://gerrit.ovirt.org/35361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
