Simone Tiraboschi has posted comments on this change.

Change subject: packaging: setup: fixing the check of ISO image permission
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/35792/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-12-02 14:15:09 +0100
Line 4: Commit:     Simone Tiraboschi <stira...@redhat.com>
Line 5: CommitDate: 2014-12-02 14:15:09 +0100
Line 6: 
Line 7: packaging: setup: fixing the cehck of ISO image permission
> check
Done
Line 8: 
Line 9: Fixing ISO image permission check against qemu user
Line 10: 
Line 11: Change-Id: I3445e536f4f22b7ccdad1163b4be8afe1c8a69af


http://gerrit.ovirt.org/#/c/35792/1/src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py
File src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py:

Line 78:                 self.execute(
Line 79:                     (
Line 80:                         self.command.get('sudo'),
Line 81:                         '-u',
Line 82:                         'qemu',
> not sure this is enough.
I tried it with 
   -rw-------. 1 qemu kvm 3782213632  2 dic 13:56 /tmp/rhel66.iso
and it seams to work as expected.
Line 83:                         'test',
Line 84:                         '-r',
Line 85:                         realpath,
Line 86:                     ),


-- 
To view, visit http://gerrit.ovirt.org/35792
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3445e536f4f22b7ccdad1163b4be8afe1c8a69af
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to