Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: fixing the cehck of ISO image permission ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35792/1/src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py File src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py: Line 78: self.execute( Line 79: ( Line 80: self.command.get('sudo'), Line 81: '-u', Line 82: 'qemu', not sure this is enough. I'm not aware of vdsm using the iso but to be safe, since both vdsm and qemu are in kvm group, maybe we should verify somehow if it's readable by the group like using nobody/kvm and then checking if vdsm and qemu can read it as users... what do you think? Line 83: 'test', Line 84: '-r', Line 85: realpath, Line 86: ), -- To view, visit http://gerrit.ovirt.org/35792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3445e536f4f22b7ccdad1163b4be8afe1c8a69af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
