Roy Golan has posted comments on this change. Change subject: core: Monitoring - refactor Host newtork error handling ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/35521/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java: Line 44: @Override Line 45: protected void executeVDSCommand() { Line 46: if (_vdsManager != null) { Line 47: try { Line 48: _vdsManager.getLockObj().lock(); > why did you change this? I didn't revert this properly. will clean it.a I'm of that idea. I thought that lots of incoming error handling events would come in and would contend on the lock. after researching that I saw no problem with it and decided to let off the Lock object. Line 49: executeVdsIdCommand(); Line 50: } finally { Line 51: _vdsManager.getLockObj().unlock(); Line 52: } -- To view, visit http://gerrit.ovirt.org/35521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59d26baa4d372905c8249edb0aabe28ea4c4a74a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
