Omer Frenkel has posted comments on this change. Change subject: core: Monitoring - refactor Host newtork error handling ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/35521/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 472: if (!statsReturnValue.getSucceeded() Line 473: && statsReturnValue.getExceptionObject() != null) { Line 474: log.error(" Failed getting vds stats, vds='{}'({}): {}", Line 475: vds.getName(), vds.getId(), statsReturnValue.getExceptionString()); Line 476: return; i think we still need to throw the exception.. no? what if its "recovering" exception? treatment is in the caller.. am i missing something? Line 477: } Line 478: // save also dynamic because vm_count data and image_check getting with Line 479: // statistics data Line 480: // TODO: omer- one day remove dynamic save when possible please check if vdsDynamic changed before save http://gerrit.ovirt.org/#/c/35521/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java: Line 44: @Override Line 45: protected void executeVDSCommand() { Line 46: if (_vdsManager != null) { Line 47: try { Line 48: _vdsManager.getLockObj().lock(); why did you change this? Line 49: executeVdsIdCommand(); Line 50: } finally { Line 51: _vdsManager.getLockObj().unlock(); Line 52: } -- To view, visit http://gerrit.ovirt.org/35521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59d26baa4d372905c8249edb0aabe28ea4c4a74a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
