Alon Bar-Lev has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 21: (3 comments) http://gerrit.ovirt.org/#/c/35485/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainQuery.java: Line 33: ProviderProxy proxy = ProviderProxyFactory.getInstance().create(provider); Line 34: List<? extends Certificate> chain = proxy.getCertificateChain(); Line 35: if (!chain.isEmpty()) { Line 36: try { Line 37: getQueryReturnValue().setReturnValue(Arrays.<CertificateInfo> asList(createCertificateInfo(chain.get(chain.size() - 1)))); this query as it called should return the entire chain. the selection of 1st certificate is up to caller. Line 38: } catch (CertificateEncodingException e) { Line 39: getQueryReturnValue().setSucceeded(false); Line 40: log.error("Error in encoding certificate. Error is {} " + e.getMessage()); Line 41: if (log.isDebugEnabled()) { Line 43: } Line 44: } Line 45: getQueryReturnValue().setSucceeded(true); Line 46: } else { Line 47: getQueryReturnValue().setSucceeded(false); maybe: getQueryReturnValue().setSucceeded(false); try { if and stuff getQueryReturnValue().setSucceeded(true); } ... Line 48: } Line 49: } Line 50: Line 51: private CertificateInfo createCertificateInfo(final Certificate cert) throws CertificateEncodingException { http://gerrit.ovirt.org/#/c/35485/21/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CertificateMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CertificateMapper.java: Line 23: @Mapping(from = CertificateInfo.class, to = Certificate.class) Line 24: public static Certificate map(CertificateInfo entity, Certificate template) { Line 25: Certificate model = template != null ? template : new Certificate(); Line 26: model.setContent(entity.getPayload()); Line 27: model.setSubject(entity.getDescription()); so we need to add subject as well, the description should be something else. I mean if subject is actually a subject then either generate certificate out of payload and extract subject or hold subject in the CertificateInfo. I am planning to add fingerprint and issuer to description. Line 28: return model; Line 29: } -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
