Alon Bar-Lev has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 21: (1 comment) http://gerrit.ovirt.org/#/c/35485/21/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3045: aQuery.converterCallback = new IAsyncConverter() { Line 3046: @Override Line 3047: public Object Convert(Object source, AsyncQuery _asyncQuery) Line 3048: { Line 3049: if (source == null) { > Alon, this conversion has to be done, otherwise you will get the a "ReturnV I thought that most get ReturnValue and cast it when used, instead of using convertor. as I seen the convertor is used only when there is actually something to convert. but I do not mind as long as something is working :))) Line 3050: return new ArrayList<CertificateInfo>(); Line 3051: } Line 3052: return source; Line 3053: } -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
