Alon Bar-Lev has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 15: (3 comments) http://gerrit.ovirt.org/#/c/35485/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateCommand.java: renamed as we import single certificate. Line 1: package org.ovirt.engine.core.bll.provider; Line 2: Line 3: import java.io.ByteArrayInputStream; Line 4: import java.security.cert.CertificateFactory; Line 45: try { Line 46: String encoded = getParameters().getCertificate(); Line 47: if (encoded != null && !encoded.isEmpty()) { Line 48: throw new RuntimeException("Certificate is missing"); Line 49: } restapi now query certificate then import, and we enforce test at ui, so no reason to query host here. Line 50: Line 51: try (ByteArrayInputStream bis = new ByteArrayInputStream(new Base64(0).decode(encoded))) { Line 52: ExternalTrustStoreInitializer.addCertificate(CertificateFactory.getInstance("X.509").generateCertificate(bis)); Line 53: } http://gerrit.ovirt.org/#/c/35485/15/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendExternalProviderResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendExternalProviderResource.java: Line 85: if (providerCertificatesResult == null Line 86: || !providerCertificatesResult.getSucceeded() Line 87: || providerCertificatesResult.getReturnValue() == null) { Line 88: return null; Line 89: } I have no clue what I am doing above, but it should be the following: 1. execute the GetProviderCertificateChain2 query. 2. execute the ImportProviderCertificate command with 1st certificate from (1). Line 90: return performAction(VdcActionType.ImportProviderCertificate, Line 91: new ImportProviderCertificateParameters(provider, Line 92: ((List<CertificateInfo>)providerCertificatesResult.getReturnValue()).get(0).getPayload())); Line 93: } -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
