Alon Bar-Lev has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 14: (3 comments) http://gerrit.ovirt.org/#/c/35485/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java: Line 39: public static void saveTrustStore(KeyStore keystore) { Line 40: File trustStoreFile = EngineLocalConfig.getInstance().getExternalProvidersTrustStore(); Line 41: File tempFile = null; Line 42: try { Line 43: tempFile = File.createTempFile("keystore", ".tmp", trustStoreFile.getParentFile()); either revert or move to correct patch. Line 44: try (FileOutputStream out = new FileOutputStream(tempFile)) { Line 45: keystore.store(out, EngineLocalConfig.getInstance() Line 46: .getExternalProvidersTrustStorePassword() Line 47: .toCharArray()); http://gerrit.ovirt.org/#/c/35485/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java: Line 41 Line 42 Line 43 Line 44 Line 45 we can reduce diff. Line 81: Line 82: private void saveChainToTrustStore(List<? extends Certificate> chain) { Line 83: if (chain != null && chain.size() > 0) { Line 84: try { Line 85: for (Certificate cert : chain) { should be move to original patch. Line 86: ExternalTrustStoreInitializer.addCertificate(cert); Line 87: } Line 88: setSucceeded(true); Line 89: } catch (Throwable e) { -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
