Yedidyah Bar David has posted comments on this change. Change subject: core: support different exit codes ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/35632/1/README.environment File README.environment: Line 48: Line 49: BASE/exitCode(list) Line 50: List of dictionary entires, keys are priority, code. Line 51: Highest priority wins. Line 52: Keys should be based on Stages.PRIORITY_*. > Doesn't seem semantically correct using stages priorities for exit code pri I agree but do not think we need another set of priorities. Line 53: Line 54: BASE/suppressEnvironmentKeys(list) Line 55: Suppress output of environment keys. Line 56: http://gerrit.ovirt.org/#/c/35632/1/src/otopi/__main__.py File src/otopi/__main__.py: Line 128: return ( Line 129: constants.Const.EXIT_CODE_GENERAL_ERROR Line 130: if code == constants.Const.EXIT_CODE_SUCCESS Line 131: else code Line 132: ) Due to your exact choice of numbers, could have been: return max(self._getExitCode(installer.environment), constants.Const.EXIT_CODE_GENERAL_ERROR) ... Line 133: Line 134: if __name__ == '__main__': Line 135: installer = Installer() Line 136: sys.exit(installer.main()) -- To view, visit http://gerrit.ovirt.org/35632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b330bb3eaccc05798343931ff3feb70e43e0259 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
