Yedidyah Bar David has posted comments on this change. Change subject: core: support different exit codes ......................................................................
Patch Set 3: Without a function, http://gerrit.ovirt.org/35503, instead of the current: self.addExitCode(code=11) (or with '11' replaced with a constant), would have been: self.environment[ otopicons.BaseEnv.EXIT_CODE ].append( { 'code':11, 'priority': plugin.Stages.PRIORITY_DEFAULT } ) This: 1. is longer 2. requires every user to explicitly set priority, or makes _getExitCode more complex (supposing default if none provided) 3. Exports the implementation (preventing e.g. one day to replace the dict with a class or whatever). -- To view, visit http://gerrit.ovirt.org/35632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b330bb3eaccc05798343931ff3feb70e43e0259 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
