Shubhendu Tripathi has posted comments on this change.

Change subject: webadmin: UI for gluster volume snapshot create
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/35082/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java:

Line 34:         ViewIdHandler idHandler = GWT.create(ViewIdHandler.class);
Line 35:     }
Line 36: 
Line 37:     @UiField
Line 38:     WidgetStyle style;
> You aren't using this right? I think your checkboxes appear as :
yes. would do that
Line 39: 
Line 40:     @UiField
Line 41:     @Path(value = "clusterName.entity")
Line 42:     @WithElementId


-- 
To view, visit http://gerrit.ovirt.org/35082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to