anmolbabu has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshot create ......................................................................
Patch Set 4: (7 comments) Please move packaging/dbscripts/upgrade/03_06_0520_add_gluster_volume_snapshot_tables.sql out of UI patch. Also, please undo the unintentional modifications done by eclipse formatter to the other code http://gerrit.ovirt.org/#/c/35082/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 133: Line 134: public void setStopRebalanceCommand(UICommand stopRebalanceCommand) { Line 135: this.stopRebalanceCommand = stopRebalanceCommand; Line 136: } Line 137: New line Line 138: private UICommand statusRebalanceCommand; Line 139: Line 140: public UICommand getStatusRebalanceCommand() { Line 141: return statusRebalanceCommand; Line 220: SearchObjects.GLUSTER_VOLUME_PLU_OBJ_NAME }); Line 221: setAvailableInModes(ApplicationMode.GlusterOnly); Line 222: Line 223: setNewVolumeCommand(new UICommand("Create Volume", this)); //$NON-NLS-1$ Line 224: setNewSnapshotCommand(new UICommand("Create Snapshot", this)); //$NON-NLS-1$ Please name it in camel case like "CreateSnapshot" Line 225: setRemoveVolumeCommand(new UICommand("Remove", this)); //$NON-NLS-1$ Line 226: setStartCommand(new UICommand("Start", this)); //$NON-NLS-1$ Line 227: setStopCommand(new UICommand("Stop", this)); //$NON-NLS-1$ Line 228: setStartRebalanceCommand(new UICommand("StartRebalance", this)); //$NON-NLS-1$ Line 668: selectedVolumes.add((GlusterVolumeEntity) selectedVolume); Line 669: } Line 670: optimizeVolumesForVirtStore(selectedVolumes); Line 671: } else if (command.getName().equalsIgnoreCase("Create Snapshot")) {//$NON-NLS-1$ Line 672: newSnapshot(); please use camel case Line 673: } else if (command.getName().equalsIgnoreCase("onCreateSnapshot")) {//$NON-NLS-1$ Line 674: onCreateSnapshot(); Line 675: } Line 676: } http://gerrit.ovirt.org/#/c/35082/4/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java: Line 429: Line 430: String AuditLogType___VOLUME_SNAPSHOT_CREATE(); Line 431: Line 432: String AuditLogType___VOLUME_SNAPSHOT_CREATE_FAILED(); Line 433: VdcActonType entries ? Line 434: String VdcActionType___ActivateVds(); Line 435: Line 436: String VdcActionType___RecoveryStoragePool(); Line 437: http://gerrit.ovirt.org/#/c/35082/4/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties File frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties: Line 213: AuditLogType___GLUSTER_BRICK_STATUS_CHANGED=Detected change in status of brick Line 214: AuditLogType___GLUSTER_VOLUME_REBALANCE_NOT_FOUND_FROM_CLI=Could not find information for rebalance on volume from CLI. Marking it as unknown. Line 215: AuditLogType___REMOVE_GLUSTER_VOLUME_BRICKS_NOT_FOUND_FROM_CLI=Could not find information for remove brick on volume from CLI. Marking it as unknown. Line 216: AuditLogType___VOLUME_SNAPSHOT_CREATE=Snapshot created for the volume Line 217: AuditLogType___VOLUME_SNAPSHOT_CREATE_FAILED=Failed create snapshot for the volume VdcActonType entries ? Line 218: Line 219: Line 220: VdcActionType___ActivateVds=Activate Host Line 221: VdcActionType___RecoveryStoragePool=Reinitialize Data Center http://gerrit.ovirt.org/#/c/35082/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java: Line 34: ViewIdHandler idHandler = GWT.create(ViewIdHandler.class); Line 35: } Line 36: Line 37: @UiField Line 38: WidgetStyle style; You aren't using this right? I think your checkboxes appear as : Text to left and check box on right But, looks like Ovirt UI convention is to have the reverse. Please refer : http://gerrit.ovirt.org/#/c/29691/26/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java to keep it consistent with oVirt UI conventions Line 39: Line 40: @UiField Line 41: @Path(value = "clusterName.entity") Line 42: @WithElementId Line 82: super(eventBus, resources); Line 83: this.messages = messages; Line 84: this.constants = constants; Line 85: this.templates = templates; Line 86: initEditors(); Please remove initEditors Line 87: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this)); Line 88: ViewIdHandler.idHandler.generateAndSetIds(this); Line 89: localize(); Line 90: driver.initialize(this); -- To view, visit http://gerrit.ovirt.org/35082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
