Alona Kaplan has posted comments on this change. Change subject: engine: Enforce maximal QoS commitment on interface ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/34133/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 385: } else { Line 386: Integer speed = null; Line 387: if (iface.hasSpeed()) { Line 388: // vdsm reported some speed for this interface, use it Line 389: speed = iface.getSpeed(); Are you sure vlan device has speed? What about newly created vlan device? Shouldn't you take the speed from the base interface? Line 390: } else { Line 391: // vdsm didn't report any speed - if this is a new bond, calculate its speed Line 392: Iterable<VdsNetworkInterface> slaves = bonds.get(ifaceName); Line 393: if (slaves != null) { -- To view, visit http://gerrit.ovirt.org/34133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc89f4193d6b7b590c6e1e053af74ab23bc77a11 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
