Alona Kaplan has posted comments on this change. Change subject: engine: Enforce maximal QoS commitment on interface ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/34133/14/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java: Line 479: VdcBllMessages.ACTION_TYPE_FAILED_HOST_NETWORK_QOS_INTERFACES_WITHOUT_QOS, Line 480: BOND_NAME); Line 481: } Line 482: Line 483: private SetupNetworksHelper qosCommitmentSetup(int totalCommitment, Please add the same commitment tests also for overridden qos and commitment tests for non-bond interfaces. Line 484: Integer slaveSpeed, Line 485: Integer bondSpeed, Line 486: String bondOptions) { Line 487: -- To view, visit http://gerrit.ovirt.org/34133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc89f4193d6b7b590c6e1e053af74ab23bc77a11 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
