Roy Golan has posted comments on this change. Change subject: CpuTune - use previous value if quota or period is None ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35329/1/mom/Controllers/CpuTune.py File mom/Controllers/CpuTune.py: Line 30: quota = guest.GetControl('vcpu_quota') Line 31: period = guest.GetControl('vcpu_period') Line 32: prev_quota = guest.vcpu_quota Line 33: prev_period = guest.vcpu_period Line 34: quota = quota if quota != prev_quota and not None else prev_quota > It calls the setVmCpuTune even when nothing has changed. We wanted to avoid there was confusion here. I understood something else from you. nevermind, fixing this as it makes more sense not to call it each time with same params Line 35: period = period if period != prev_period and not None else prev_period Line 36: quota = int(quota) Line 37: period = int(period) Line 38: uuid = guest.Prop('uuid') -- To view, visit http://gerrit.ovirt.org/35329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
