Roy Golan has uploaded a new change for review.
Change subject: CpuTune - use previous value if quota or period is None
......................................................................
CpuTune - use previous value if quota or period is None
The policy may not set the value of quota or period if it detected no
change. the controller than isn't performing the call to setVmCpuTune.
Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M mom/Controllers/CpuTune.py
1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/mom refs/changes/29/35329/1
diff --git a/mom/Controllers/CpuTune.py b/mom/Controllers/CpuTune.py
index 687f7bc..7f0c8db 100644
--- a/mom/Controllers/CpuTune.py
+++ b/mom/Controllers/CpuTune.py
@@ -29,16 +29,17 @@
def process_guest(self, guest):
quota = guest.GetControl('vcpu_quota')
period = guest.GetControl('vcpu_period')
- if quota is not None and period is not None:
- quota = int(quota)
- period = int(period)
- uuid = guest.Prop('uuid')
- name = guest.Prop('name')
- prev_quota = guest.vcpu_quota
- prev_period = guest.vcpu_period
- self.logger.info("CpuTune guest:%s from quota:%s period:%s to
quota:%s period:%s", \
- name, prev_quota, prev_period, quota, period)
- self.hypervisor_iface.setVmCpuTune(uuid, quota, period)
+ prev_quota = guest.vcpu_quota
+ prev_period = guest.vcpu_period
+ quota = quota if quota != prev_quota and not None else prev_quota
+ period = period if period != prev_period and not None else prev_period
+ quota = int(quota)
+ period = int(period)
+ uuid = guest.Prop('uuid')
+ name = guest.Prop('name')
+ self.logger.info("CpuTune guest:%s from quota:%s period:%s to quota:%s
period:%s", \
+ name, prev_quota, prev_period, quota, period)
+ self.hypervisor_iface.setVmCpuTune(uuid, quota, period)
def process(self, host, guests):
for guest in guests:
--
To view, visit http://gerrit.ovirt.org/35329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd
Gerrit-PatchSet: 1
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
