Arik Hadas has posted comments on this change. Change subject: Engine: Pre-started vms in vm pool display bad auditlog message ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35394/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 570: boolean isVdsKnown = getVds() != null; Line 571: if (isStateless && isVdsKnown) { Line 572: return AuditLogType.VDS_INITIATED_RUN_VM_AS_STATELESS; Line 573: } else if (isStateless && !isVdsKnown) { Line 574: return AuditLogType.UNASSIGNED; isStateless && isVdsKnown or isStateless && !isVdsKnown is already true if isStateless=true so the clause in 575 is redundant, something seems wrong here.. Line 575: } else if (isStateless) { Line 576: return AuditLogType.VDS_INITIATED_RUN_AS_STATELESS_VM_NOT_YET_RUNNING; Line 577: } else { Line 578: return AuditLogType.VDS_INITIATED_RUN_VM; -- To view, visit http://gerrit.ovirt.org/35394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ce736c1b24265a13b147ffae235428ddbd597e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
