Eli Mesika has posted comments on this change. Change subject: core: QoS name uniquness ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34154/5/packaging/dbscripts/upgrade/03_06_0540_qos_name_uniqueness.sql File packaging/dbscripts/upgrade/03_06_0540_qos_name_uniqueness.sql: Line 1: -- adding constaint for qos name uniqueness of same context Line 2: ALTER TABLE qos ADD UNIQUE (qos_type, name, storage_pool_id) > right but you don't want to take the risk of failing. That means that the upgrade will fail, therefor I expect handling this explicitly in this script before altering the table with the UNIQUE constraint -- To view, visit http://gerrit.ovirt.org/34154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16c75592dd8a8745ecffc7728e6523de8be4f857 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
