Eli Mesika has posted comments on this change. Change subject: core: QoS name uniquness ......................................................................
Patch Set 7: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/34154/7/packaging/dbscripts/upgrade/03_06_0580_qos_name_uniqueness.sql File packaging/dbscripts/upgrade/03_06_0580_qos_name_uniqueness.sql: Line 15: loop Line 16: fetch v_cur into v_entry; Line 17: -- since the cursor is ordered, check that 2 consecutive rows not match Line 18: if (v_entry.qos_type = v_qos_type and v_entry.name = v_name and v_entry.storage_pool_id = v_storage_pool_id) then Line 19: update qos set name = v_name || cast(uuid_generate_v1() as varchar) where id = v_entry.id; worth to add "_" in order to find easily the original name update qos set name = v_name || '_' || cast(uuid_generate_v1() as varchar) where id = v_entry.id; Line 20: end if; Line 21: exit when not found; Line 22: v_qos_type := v_entry.qos_type; Line 23: v_name := v_entry.name; -- To view, visit http://gerrit.ovirt.org/34154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16c75592dd8a8745ecffc7728e6523de8be4f857 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
