Lior Vernia has posted comments on this change. Change subject: engine,webadmin: Replace references to NetworkQoS with HostNetworkQos ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/34131/13/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java: > Please add tests for the cases validateNetworkQos returns Done Line 1: package org.ovirt.engine.core.bll.network.host; Line 2: Line 3: import static org.junit.Assert.assertEquals; Line 4: import static org.junit.Assert.assertTrue; http://gerrit.ovirt.org/#/c/34131/13/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java: Line 381: } Line 382: Line 383: private void updateQosChangeability() { Line 384: getQosModel().setIsChangable(getQosOverridden().getEntity() Line 385: && (!getIsToSync().getIsChangable() || getIsToSync().getEntity())); > I would check getQosOverridden().getIsChangeable() instead of (!getIsToSync Done Line 386: } Line 387: Line 388: private void bootProtocolChanged() Line 389: { -- To view, visit http://gerrit.ovirt.org/34131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6a625d8c5b554cb525efc41d31013df0de2a146 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
