Alona Kaplan has posted comments on this change. Change subject: engine,webadmin: Replace references to NetworkQoS with HostNetworkQos ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/34131/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 256: addViolation(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NETWORK_QOS_NOT_SUPPORTED, iface.getNetworkName()); Line 257: } Line 258: Line 259: HostNetworkQosValidator qosValidator = new HostNetworkQosValidator(iface.getQos()); Line 260: if (qosValidator.requiredValuesPresent() != ValidationResult.VALID) { > They're validated as part of HostNetworkQosValidatorTest... What validation Yes. It should be added to SetupNetworksHelperTest. Line 261: addViolation(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NETWORK_QOS_SETUP_NETWORKS_MISSING_VALUES, Line 262: iface.getNetworkName()); Line 263: } Line 264: if (qosValidator.valuesConsistent() != ValidationResult.VALID) { -- To view, visit http://gerrit.ovirt.org/34131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6a625d8c5b554cb525efc41d31013df0de2a146 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
