Eli Mesika has posted comments on this change.
Change subject: core: when iso domain is inactive we still go to the cache
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
Line 45: } else if
((VmRunHandler.getInstance().findActiveISODomain(getVm().getstorage_pool_id())
== null) && !StringHelper.isNullOrEmpty(mCdImagePath)) {
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 214: res=false;
We had a discussion on one return point VS multiple return point and got the
conclusion that both are legal
Line 217: return res;
same
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 291: boolean isIsoFound =
(VmRunHandler.getInstance().findActiveISODomain(storagePoolId) != null);
Done
--
To view, visit http://gerrit.ovirt.org/5184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d24c94c4dd630c5a76ae1fee65bee257b5e40f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
