Alexander Wels has posted comments on this change. Change subject: core: Create PairQueryable ID without UUID serialization ......................................................................
Patch Set 1: (1 comment) One minor comment but looks good to me otherwise. http://gerrit.ovirt.org/#/c/35198/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java: Line 18: } Line 19: Line 20: private Pair<T, K> getPair() { Line 21: if (pair == null) { Line 22: pair = new Pair<>(null, null); Can't you do: pair = new PairQueryableId(); Line 23: } Line 24: return pair; Line 25: } Line 26: -- To view, visit http://gerrit.ovirt.org/35198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
