Moti Asayag has posted comments on this change. Change subject: core: Create PairQueryable ID without UUID serialization ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35198/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java: Line 67: } Line 68: Line 69: @Override Line 70: public PairQueryableId getQueryableId() { Line 71: return new PairQueryableId(getMemberId(getFirst()), getMemberId(getSecond())); wouldn't instantiating the PairQueryableId each time this method is being called will inherit the need to invoked PairQueryableId.serializeId() ? Line 72: } Line 73: Line 74: private Object getMemberId(IVdcQueryable member) { Line 75: if (member != null) { -- To view, visit http://gerrit.ovirt.org/35198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
