Lior Vernia has posted comments on this change. Change subject: core: add keystone url field to external providers ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/34880/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 48 Line 49 Line 50 Line 51 Line 52 Is this enum value in ConfigurationValues still used by any piece of code, or can it be removed? Line 440: String errorMessage = EMPTY_ERROR_MESSAGE; Line 441: if (result == null || !result.getSucceeded()) { Line 442: if (result != null) { Line 443: errorMessage = Frontend.getInstance().translateVdcFault(result.getFault()); Line 444: } else if ((Boolean) requiresAuthentication.getEntity() && StringHelper.isNullOrEmpty(getAuthUrl().toString())) { I think this clause is now dead code and can be removed - since authUrl is validated as part of validateConnectionSettings(), which happens prior to clicking the "Test" button, it shouldn't be possible for this to be the reason for failure following the button press. Line 445: errorMessage = ConstantsManager.getInstance().getConstants().noAuthUrl(); Line 446: } else { Line 447: errorMessage = ConstantsManager.getInstance().getConstants().testFailedUnknownErrorMsg(); Line 448: } Line 441: if (result == null || !result.getSucceeded()) { Line 442: if (result != null) { Line 443: errorMessage = Frontend.getInstance().translateVdcFault(result.getFault()); Line 444: } else if ((Boolean) requiresAuthentication.getEntity() && StringHelper.isNullOrEmpty(getAuthUrl().toString())) { Line 445: errorMessage = ConstantsManager.getInstance().getConstants().noAuthUrl(); Then this constant could be removed. Line 446: } else { Line 447: errorMessage = ConstantsManager.getInstance().getConstants().testFailedUnknownErrorMsg(); Line 448: } Line 449: } -- To view, visit http://gerrit.ovirt.org/34880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1aa930cd8dec576a6408402dd883ab5162e1f9d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
